Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785479 --- Comment #9 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- (In reply to comment #8) ===== MUST items ===== [!]: Package requires other packages for directories it uses. [!]: Package must own all directories that it creates. Since Horde_Test not required yet, "%dir %{pear_phpdir}/Horde" must be used in %files. ===== SHOULD items ===== [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. ===== COULD items ===== * Localized php.ini not necessary * In %files, "%{pear_testdir}/Horde_Constraint" could be changed to "%{pear_testdir}/%{pear_name}" -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yfH7vJoH32&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review