[Bug 878660] Review Request: openshift-origin-node-util - Utility scripts for the OpenShift Origin node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878660

--- Comment #7 from Michael Scherer <misc@xxxxxxxx> ---
The files are already in /sbin, so if people do not understand that it would
not work, I think there is a problem. Anyway, if upstream want this way.


Now, why is there this in %post :
/sbin/restorecon /usr/sbin/oo-restorer* || :

This look like a work around some selinux integration bug or something like
that, and this doesn't belong to the package ( IMHO ). However, I may have
missed something, so can you explain ?

There is a few issues :
- it should IMHO be updated to the latest version ( due to bug I reported )
- there is macros missing for systemd integration

Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Permissions on files are set properly.
  Note: See rpmlint output
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
- No macro for systemd integration in %post (
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd )
- Not the latest version ( especially due to
https://bugzilla.redhat.com/show_bug.cgi?id=880699 )

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: Package contains no bundled libraries without FESCO exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[!]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 1 files have unknown license. Detailed output of
     licensecheck in /home/misc/checkout/git/FedoraReview/878660-openshift-
     origin-node-util/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
     Note: Package contains no Conflicts: tag(s)
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: openshift-origin-node-util-1.1.6-3.fc18.noarch.rpm
openshift-origin-node-util.noarch: E: explicit-lib-dependency libcgroup-tools
openshift-origin-node-util.noarch: E: non-readable
/usr/sbin/oo-restorer-wrapper.sh 0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-restorer-wrapper.sh 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-idler-stats
0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-idler-stats 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-list-access
0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-list-access 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-init-quota
0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-init-quota 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-last-access
0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-last-access 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-app-idle 0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-app-idle 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-restorer 0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-restorer 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-idler 0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-idler 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-admin-ctl-gears
0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-admin-ctl-gears 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-setup-node
0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-setup-node 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-accept-node
0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-accept-node 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-list-stale
0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-list-stale 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-autoidler 0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-autoidler 0750L
1 packages and 0 specfiles checked; 27 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint openshift-origin-node-util
openshift-origin-node-util.noarch: E: explicit-lib-dependency libcgroup-tools
openshift-origin-node-util.noarch: E: non-readable
/usr/sbin/oo-restorer-wrapper.sh 0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-restorer-wrapper.sh 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-idler-stats
0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-idler-stats 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-list-access
0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-list-access 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-init-quota
0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-init-quota 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-last-access
0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-last-access 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-app-idle 0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-app-idle 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-restorer 0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-restorer 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-idler 0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-idler 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-admin-ctl-gears
0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-admin-ctl-gears 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-setup-node
0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-setup-node 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-accept-node
0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-accept-node 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-list-stale
0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-list-stale 0750L
openshift-origin-node-util.noarch: E: non-readable /usr/sbin/oo-autoidler 0750L
openshift-origin-node-util.noarch: E: non-standard-executable-perm
/usr/sbin/oo-autoidler 0750L
1 packages and 0 specfiles checked; 27 errors, 0 warnings.
# echo 'rpmlint-done:'



Requires
--------
openshift-origin-node-util (rpmlib, GLIBC filtered):
    /bin/bash
    /bin/sh
    /usr/bin/env
    config(openshift-origin-node-util)
    git
    httpd
    libcgroup-tools
    lsof
    oddjob
    php
    policycoreutils
    quota
    rng-tools
    rubygem-openshift-origin-node
    system-config-firewall-base



Provides
--------
openshift-origin-node-util:
    config(openshift-origin-node-util)
    openshift-origin-node-util



MD5-sum check
-------------
http://mirror.openshift.com/pub/openshift-origin/source/openshift-origin-node-util/openshift-origin-node-util-1.1.6.tar.gz
:
  CHECKSUM(SHA256) this package     :
d1482914c791825e6b31f856e3a39b213381e343bd429ad3b95a446f86b2d401
  CHECKSUM(SHA256) upstream package :
d1482914c791825e6b31f856e3a39b213381e343bd429ad3b95a446f86b2d401


Generated by fedora-review 0.2.0 (Unknown) last change: Unknown
Buildroot used: fedora-18-x86_64
Command line :./try-fedora-review -b 878660

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GOP3dh73oJ&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]