Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: hal https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225880 ------- Additional Comments From pertusus@xxxxxxx 2007-02-19 18:51 EST ------- (In reply to comment #4) > In response to comment 3: > > I've fixed most of this except making /etc/dbus-1/system.d/hal.conf > %config(noreplace). I've made it %config however as > /etc/dbus-1/system.d/hal.conf isn't a configuration at all; It defines the security policy of HAL, it is an obvious config file. You may prefer to keep it under the packager responsibility, but it is a config file. I am personally fine with having this file %config, seems like a good compromise. I think that %{_sysconfdir}/rc.d/init.d/haldaemon shouldn't be %config. Maybe you could use %_initrddir for that file. The Application category in .desktop file is deprecated. What about putting hal-info in another package? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review