Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=823351 --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Keep Gemfile and %{gem_name}.gemspec - Please consider to keep above mentioned files in -doc subpackage. Although they are not needed for runtime, they were originally shipped by upstream, so lets try to keep the modifications limited. * Move files not needed for runtime into -doc subpackage - Please consider to move following files/directories into -doc subpackage, since they are not needed for runtime IMO: %doc %{gem_instdir}/CHANGELOG.md %doc %{gem_instdir}/README.md %{gem_instdir}/benchmark %{gem_instdir}/spec %{gem_instdir}/tasks * Package does not own the binary extension directories - The "%{gem_extdir}/lib/yajl/yajl.so" means that only the yajl.so file is owned by the package. Please use "%{gem_extdir}" instead, to own the whole directory structure including the .so file. * Exclude %{gem_cache} - Please exclude %{gem_cache}. This file is not needed on Fedora. * Bundled library - This gem contains bundled YAJL library. Please work with upstream to allow to use the YAJL available on system. - I already submitted issue upstream: https://github.com/brianmario/yajl-ruby/issues/111 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LCIuKtBNXG&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review