[Bug 823333] Review Request: rubygem-mixlib-cli - a ruby gem mixin for CLI support, including option parsing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=823333

Josef Stribny <jstribny@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdunn@xxxxxxxxxxxx,
                   |                            |jstribny@xxxxxxxxxx

--- Comment #1 from Josef Stribny <jstribny@xxxxxxxxxx> ---
* Remove Requires: ruby for other Ruby interpretations to be used with in f19

* Rakefile, NOTICE and README.rdoc are not require during runtime
  - Please consider moving them into the -doc subpackage

* Please consider moving specs into the -doc subpackage rather than exclude
them

* I would suggest you to exclude %{gem_cache} as it's not needed

* Tests print:

........You must supply -r!
Usage: /usr/local/bin/rspec (options)
    -r
......

  - Tests shouldn't print STDOUT like this. It could be fixed by something
suggested on stackoverflow [1]. 

[1]
http://stackoverflow.com/questions/1496019/suppresing-output-to-console-with-ruby

@Julian C. Dunn: Adding you to CC. Could you please take over this bug?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OdowK9G40m&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]