Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815018 --- Comment #67 from Stephen Gallagher <sgallagh@xxxxxxxxxx> --- (In reply to comment #66) > Some additions: > I'd also like to see node.js in EPEL6 > So would I, but it's not going to happen. Node.js requires much newer dependencies than we have in EPEL 6. Specifically, we need openssl 1.0.1 or later as well as http_parser 2.0 or later. OpenSSL is a full-stop problem, since that's carried in the core RHEL 6 and there's no way that Red Hat is going to rebase that one. We can try to make requests that they backport the SPDY patches to OpenSSL 1.0.0, but I don't know how successful we would be there. > Running rpmlint, I've found a few issues: > nodejs.x86_64: E: non-standard-executable-perm /usr/bin/node 0775L That's strange. I don't see that when running rpmlint 1.4 on Fedora 18. I checked it against a local build and the one from Koji. Where did you see that? Regardless, I'm explicitly setting it to 0755 now to be safe. > nodejs-debuginfo.x86_64: E: debuginfo-without-sources Oof, this was a bit of a pain in the neck. They have build scripts to build either debug builds with no optimization, or fully optimized builds with no symbols. I've added a patch to deal with this. > nodejs.src:90: E: hardcoded-library-path in %{_prefix}/lib/dtrace > This is a false-positive. It's intentionally hardcoded in order to ensure that we clear out the one generated (inappropriately) during the build. It's always guaranteed to be in %{prefix}/lib (not %{_libdir}). > and licensecheck finds a few different licenses: > Apache (v2.0) > ------------- > /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/node-v0.9.3/ > tools/closure_linter/closure_linter/javascriptstatetracker.py > > Unknown or generated > -------------------- > /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/node-v0.9.3/ > tools/osx-productsign.sh > > MIT/X11 (BSD like) > ------------------ > /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/node-v0.9.3/ > src/slab_allocator.h > > BSD (3 clause) > -------------- > /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/node-v0.9.3/ > tools/js2c.py > > ISC > --- > /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/node-v0.9.3/ > test/gc/node_modules/weak/src/weakref.cc > > BSD (2 clause) > -------------- > /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/node-v0.9.3/ > deps/v8/src/arm/assembler-arm.cc > > The latter one can be ignored, IMHO, because we're using our own v8 (and > during prep deps/v8 is also cleared out). Thanks, I've added all of these. The OSX productsign one I'm assuming is covered under the Node MIT license (and it's not used when building on Linux either). According to the license guidelines, both BSD licenses fall under the "BSD" shortname, so they're both covered. SPEC: http://sgallagh.fedorapeople.org/packagereview/nodejs/nodejs.spec SRPM: http://sgallagh.fedorapeople.org/packagereview/nodejs/nodejs-0.9.3-6.fc18.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4790864 Matthias, if you're doing the review, would you mind self-assigning and setting fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pQgOS4AA2b&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review