[Bug 823337] Review Request: rubygem-mixlib-shellout - mixin for running external commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=823337

--- Comment #11 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
* Test suite fails
  - Seems that test suite depends on awesome_print?

      /usr/share/rubygems/rubygems/custom_require.rb:36:in `require': cannot
          load such file -- ap (LoadError)

    I tried to remove it and the test suite works. So please do

      sed -i "/^require 'ap'$/ s/^/#/" spec/spec_helper.rb

    and report it upstream. Nevertheless, there is still one test failure:

      1) Mixlib::ShellOut when executing the command with a current working
         directory when running under Unix should chdir to the working
directory
         Failure/Error: should eql(fully_qualified_cwd)

         expected: "/bin"
              got: "/usr/bin"

    This seems to be caused by UsrMove and should be resolved with upstream.
  - The '-Ilib' seems to be superfluous.

* I woudl move the README into -doc subpackage, but it is more the matter of
  taste.

The package looks quite good otherwise. But let's fix the test suite first.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QVkxkHOVIo&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]