Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874743 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #3 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Spec file changes: +BuildRequires: perl(base) +BuildRequires: perl(Exporter) BuildRequires: perl(ExtUtils::MakeMaker) +BuildRequires: perl(Test) +BuildRequires: perl(Module::Package) +BuildRequires: perl(Pod::Markdown) +BuildRequires: perl(Module::Package::Au) > FIX: Add missing BRs Ok %setup -q -n Unicode-EastAsianWidth-%{version} +rm -rf inc/* > FIX: Specify dependencies of inc/* (like 'perl(Cwd)' and perl(File::Path) > at inc/Module/Install.pm:24) or unbundle modules. TODO: Remove inc/* from MANIFEST find %{buildroot} -type f -name '*.bs' -empty -exec rm -f {} ';' -find %{buildroot} -depth -type d -exec rmdir {} ';' 2>/dev/null > TODO: Remove the deleting empty directories in %install section. This is > default behavior. Ok. Please consider fixing 'TODO' item. Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=R31XX6KZL9&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review