[Bug 884759] Review Request: toilet - colorful ASCII art generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=884759

Jindrich Novy <jnovy@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|                            |needinfo?(zidkova.zuzana@se
                   |                            |znam.cz)

--- Comment #8 from Jindrich Novy <jnovy@xxxxxxxxxx> ---
rpmlint output on src.rpm:

$ rpmlint toilet-0.2-0.2.fc18.src.rpm 
toilet.src: W: spelling-error Summary(en_US) figlet -> filet, fillet, piglet
-> sane as it references figlet utility

toilet.src: W: summary-not-capitalized C figlet alternative
-> could you please rephrase the Summary in a way that it starts with a capital
letter?

toilet.src: W: spelling-error %description -l en_US ancronym -> acronym,
antonym
-> there seems to be a typo in %description here

toilet.src: W: spelling-error %description -l en_US libcaca -> biblical
-> sane, it's a library name

toilet.src: W: spelling-error %description -l en_US folowing -> flowing,
following, fol owing
-> seems that 'l' is missing in "following"

toilet.src: W: spelling-error %description -l en_US colour -> color, co lour,
co-lour
-> US English prefers "color"

toilet.src: W: spelling-error %description -l en_US smushing -> mushing,
smashing, shushing
-> not sure here but 

IMO the %description seems to me too verbose with a lot of duplicities. Could
you please reduce it?

Running rpmlint on built RPM reveals:
toilet.x86_64: E: standard-dir-owned-by-package /usr/share/man/man1

So it seems it is better to own the man page like this in the %files section:
%{_mandir}/man1/%{name}*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XY9PqBhVv9&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]