Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880880 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #2 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- MUST: - Please clarify License (with upstream). Only MIT file is provided, GPLv3 only list in composer.json file... I also think it will be great to have License header in each file. - no need to requires php-common only need extensions, php-common is only required for version checking - fix the shebang Currently, in requires: /usr/bin/env #!/usr/bin/env php => #!/usr/bin/php This will fix the missing dependency on php-cli. SHOULD: - Like for a previous review, could probably be simpler to include %{libname}/scss.inc.php (without %{_datadir}/php) and override include_path for phpunit. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tZlrqqPQTq&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review