Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=886104 --- Comment #2 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> --- Since this is simple pom package I am going to skip fedora-review output and just note problems with current version. rpmlint was clean 1. License tag says ASL 2.0 but the pom.xml actually doesn't specify any license. *But* the parent pom (org.codehaus.plexus:plexus) specifies license as ASL 2.0. I've sent email to fedora-legal mailing list asking for this to be approved as a way to identify licenses for pom files. I'll add link to the email once it's approved by moderator Also if you are going to add ASL license text, you can use full url in SourceX instead of just in the comment 2. Source0 URL For maven repositories we usually use direct links. In this case (you should replace artifact names and versions with macros if possible) http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-component-factories/1.0-alpha-11/plexus-component-factories-1.0-alpha-11.pom 3. prep stage Instead of: %prep cp -p %{SOURCE0} ${RPM_BUILD_DIR}/pom.xml cp -p %{SOURCE1} LICENS do: %prep %setup -cT cp -p %{SOURCE0} pom.xml cp -p %{SOURCE1} LICENSE 4. mvn-rpmbuild verify This should be in %check section, not %build 5. short_name usage Macros for names are used when you repeatedly need to use part of a package name during install/build phase. This is not really the case here so the macro is just adding unneeded stuff to the specfile making it more complicated than it needs to be. However see next point.. 6. Upstream exists with different versions having different groupIds, you might want to add "-a "plexus:%{short_name}" to make sure that we can resolve both versions. I'd rename short_name to artifactId or something more clear 7. %files section Ideally files sections should be as specific as possible so that no new files slip by accidentally. This is not really a dealbreaker for such a simple package but keep it in mind for other packages. For this case ideal solution is: %files %doc LICENSE %{_mavenpomdir}/JPP-%{name}.pom %{_mavendepmapfragdir}/%{name} -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NqV6QamGsO&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review