Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=798071 --- Comment #11 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- A few initial comments: 1. I see no URL: tag, and this Source0: %{name}-%{version}.tar.gz references no upstream. Ideally, we'd have some URL: tag and fully-qualified downloadable (and verifiable) source for this package. If this is something that doesn't yet have an upstream, consider using http://fedorahosted.org/ 2. you seem to create a lot of "here" documents, using cat > exe/%{name}-helper <<EOF ... it's largely a matter of taste, but I personally strongly prefer and suggest you include these items as separate SourceX: items instead, and potentially work to include them in the upstream tarball someday. 3. you can most likely omit Requires: python2 python dependency should get picked up by rpm automatically (and implicitly via PyQt4 dependency too). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GrclpSZjJv&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review