[Bug 885548] Review Request: perl-DateTime-Tiny - Date object, with as little code as possible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885548

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |
              Flags|                            |fedora-review+

--- Comment #4 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Changes in spec:

-Requires:       perl(Test::More) >= 0.47
+Requires:       perl(DateTime)
> FIX: Add requires perl(DateTime) - ./lib/DateTime/Tiny.pm:355
> FIX: Remove perl(Test::More) from Requires, it is necessary only for build-time.
Ok.

-DateTime::Tiny implements an extremely lightweight object that represents a
datetime.
+DateTime::Tiny implements an extremely lightweight object that represents a
+datetime.

> FIX: Description lines must not exceed 79 characters. Please cut it to fit in
> two lines.
Ok.


TODO: Replace variable PERL_INSTALL_ROOT obsoleted with DESTDIR name in
%install.
TODO: Remove the deleting empty directories in %install section. This is
default behavior.

Please consider fixing 'TODO' items before submit.

Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kfgjoP98pv&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]