Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=839649 --- Comment #8 from Josef Stribny <jstribny@xxxxxxxxxx> --- Because it is still unresolved, I am taking this to continue with the review. 1, Summary should start with a capital "A" as mentioned above 2, Get rid of Requires: ruby BuildRequires: ruby Requires: ruby(api) will require this for you and you may use it with other interpretations of Ruby. 3, Mark %{gem_instdir}/README.md and %{gem_instdir}/MIT_LICENSE as %doc 4, Move %{gem_instdir}/rails_best_practices.gemspec and %{gem_instdir}/Gemfile to doc subpackage 5, Why do you list subfolders from %{gem_instdir}/spec/rails_best_practices/? Isn't enough to list it as one folder only? 6, Consider upgrading it to the latest upstream version (1.13.1) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=p73aQlq63O&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review