[Bug 883512] Review Request: libforensic1394 - A library for performing live memory forensics over firewire

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=883512

--- Comment #2 from Michael Schwendt <mschwendt@xxxxxxxxx> ---
> there's a lot of documentation, (358400 bytes in 49 files)

Where does "a lot" start for you? ;)

358KB for a -devel subpackage is a joke. The resulting -devel package for
x86_64 is just around 8 KiB!

It gets less funny size-wise when the documentation adds 2MB or 3MB to the size
of the RPM package, or hundreds of files, but only if too many -devel packages
do this (as that increases the time it takes to populate the buildroot).

[...]

Anyway, it's good to mention the related guidelines, but IMO you should be more
explicit about why you recommend a -doc package. Neither 385400 bytes nor 49
files sounds convincing to a packager, who's not a packaging newbie.
https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation

The ReviewGuidelines say:

| MUST: Large documentation files must go in a -doc subpackage.
| (The definition of large is left up to the packager's best judgement,
| but is not restricted to size. Large can refer to either size or quantity). 

[...]

> %files
> %doc AUTHORS COPYING COPYING.LESSER README

> %files devel
> %doc COPYING COPYING.LESSER docs/docs/html

>%files -n python-%{s_name}
> %doc COPYING COPYING.LESSER

The following applies:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jeh5aAOAzI&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]