[Bug 885495] Review Request: python-keyczar - open source cryptographic toolkit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=885495

Eduardo Echeverria <echevemaster@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |echevemaster@xxxxxxxxx

--- Comment #1 from Eduardo Echeverria <echevemaster@xxxxxxxxx> ---
Hi Maxim

In epel5 the packages that install python modules needs to define
python_sitelib or python to indicate where to find the python directory and
what modules are installed in, This is no needed in the latest releases of
Fedora.

Also

%if 0%{?rhel} <= 5                                                              
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-buildroot                  
%endif 

not correct, should be:

%if 0%{?rhel} && 0%{?rhel} <= 5
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
%endif

http://fedoraproject.org/wiki/Packaging:Python#Macros

Now,  if you want to provide this package to epel5, see
https://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Distribution_specific_guidelines


The entry

%{python_sitelib}/*

should be

%{python_sitelib}/

see: https://fedoraproject.org/wiki/Packaging:UnownedDirectories

- The package appears to contain unit tests, if so should run the tests, see
the directory "tests" in the tarball, speciffically alltests.py  

kind regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qlxB6S5AW8&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]