[Bug 884876] Review Request: openscad-MCAD - OpenSCAD Parametric CAD Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=884876

--- Comment #4 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4771303


$ rpmlint -i -v *openscad-MCAD.src: I: checking
openscad-MCAD.src: W: spelling-error %description -l en_US moching -> mooching,
moshing, mocking
The value of this tag appears to be misspelled. Please double-check.

openscad-MCAD.src: I: checking-url https://www.github.com/openscad/MCAD
(timeout 10 seconds)
openscad-MCAD.src: W: no-%build-section
The spec file does not contain a %build section.  Even if some packages don't
directly need it, section markers may be overridden in rpm's configuration to
provide additional "under the hood" functionality, such as injection of
automatic -debuginfo subpackages.  Add the section, even if empty.

openscad-MCAD.src: W: invalid-url Source0:
openscad-MCAD-20121031git9af89906fa.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

openscad-MCAD.noarch: I: checking
openscad-MCAD.noarch: W: spelling-error %description -l en_US moching ->
mooching, moshing, mocking
The value of this tag appears to be misspelled. Please double-check.

openscad-MCAD.noarch: I: checking-url https://www.github.com/openscad/MCAD
(timeout 10 seconds)
openscad-MCAD.spec: W: no-%build-section
The spec file does not contain a %build section.  Even if some packages don't
directly need it, section markers may be overridden in rpm's configuration to
provide additional "under the hood" functionality, such as injection of
automatic -debuginfo subpackages.  Add the section, even if empty.

openscad-MCAD.spec: W: invalid-url Source0:
openscad-MCAD-20121031git9af89906fa.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

2 packages and 1 specfiles checked; 0 errors, 6 warnings.

Your package looks fine. The openscad package provides the folder
%{_datadir}/openscad/libraries/ which otherwise would stay unowned. The license
declaration is somewhat difficult but sufficiently explained in the comments.
Just the issue about the missing %build section needs attention. Please add it,
regardless of whether it is really needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HiKsQaGpP9&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]