Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885467 Dan Horák <dan@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |dan@xxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |dan@xxxxxxxx Flags| |fedora-review? --- Comment #1 from Dan Horák <dan@xxxxxxxx> --- formal review is here, see the notes explaining OK* and BAD statuses below: OK source files match upstream: fd85ecd43667ffbc2e644ac6c72be5dea6104ac4 pdfedit-0.4.5.tar.bz2 OK package meets naming and versioning guidelines. OK* specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible (GPLv2). License text included in package. OK latest version is being packaged. OK* BuildRequires are proper. OK compiler flags are appropriate. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. OK* rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. BAD correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK is a GUI app with desktop file - you can drop the %clean section, the rm -rf $RPM_BUILD_ROOT command in %install and the %defattr() in %files, rpm does it automagically since RHEL-6 and F-12 - you can use motif on Fedora >= 17 (the real thing, Provides also "openmotif") instead of lesstif, so another %ifdef gone (and I prefer one BuildRequires: per line, but naturally not a blocker) - rpmlint complains a bit the spelling errors for pdf and GUI are false positives, maybe PDF could be used instead reports incorrect FSF address in some files %{_docdir}, %{name} and %{version} macros used in a comment on line 55 => can be ignored - the icon-cache scriptlets should be updated to the actual version http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - the ABRT config file should be reviewed if it still matches the actual ABRT -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=H8r3zgL5cD&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review