Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882508 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #4 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- I'll echo some comments from the previous dup'd review, naming: ok sources: ok md5sum *.bz2 90cce750e5412d43ce075b0a9bdb6782 appmenu-qt-0.2.6.tar.bz2 license: ok (or use Kevin's suggestion) macros: ok 1. could use some polish, SHOULD be using fedora's %_qt4_plugindir macro instead of hard-coding %{_libdir}/qt4/plugins scriptlets: n/a otherwise, it's a relatively simple package, I see nothing else that needs work. As far as I'm concerned, item 1 is relatively cosmetic, and it's ok with me as long as it is addressed prior to doing any official fedora builds. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aIwdWcsa0X&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review