Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858841 --- Comment #36 from Gregor Tätzner <gregor@xxxxxxxxxx> --- (In reply to comment #35) > Should config.sample.php go in %doc instead of the config directory? I don't > have a strong feeling here; I think we're inconsistent as a distro and I > don't see a guideline offhand. agreed, moved to doc > > Shouldn't PEAR5.php and PEAR-LICENSE be removed along with the other pear > files? thanks, I've overlooked those > > And, I'm sorry for not saying this sooner, but I was re-reading the bundled > libraries rules and I think we need to either split out or go through the > bundled-library-exception process for the remaining stuff under 3rdparty. (A > lot of it may fall under "copylibs" > https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Copylibs) (I > know you're working on jquery at bug #857992). This may have the benefit of > making the License field less insane. :) okay let's see what we have left: 3 php libs: smb4php (single php class, newest release, 5 years old) php-when (single php class, 2 years old) phpass (2 files, probably dead upstream) How should I cope with them? The copylib rule doesn't apply here I suppose? Also there are 3 js-libs (chosen, fullcalender and timepicker) that I don't want to touch. I will try to get an exception... > > > > On a less difficult note, maybe some of the text from > http://owncloud.org/about/ could go in the description? aye > > > I think it'd be nice for the description of the database subpackages to make > clear that it's intentional for them to be empty. Alternately, they could > contain doc files for configuration with that particular database? Not a > review blocker. good idea, I'll write some database configuration instructions (actually you just need to create an user and a database) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kBuznL6ERE&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review