[Bug 884604] Review Request: rubygem-riot - An extremely fast, expressive, and context-driven unit-testing framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=884604

--- Comment #2 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> ---
- %{gem_instdir}/MIT-LICENSE should be marked as %doc
- It is customary to keep %{gem_instdir}/%{gem_name}.gemspec in the -doc
subpackage, but not mandatory, so this is not a blocker.
- You can avoid the for loops and sedding in %check by using -Ilib:test for
testrb. That way, teststrap will be on loadpath and will load ok.
- License seems to be MIT, not Ruby or GPLv2.
- File %{gem_instdir}/.yardopts is useless from Fedora POV and should be
excluded.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XY7gfmQN7e&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]