Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: zlib https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226671 varekova@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |varekova@xxxxxxxxxx Flag| |fedora-review? ------- Additional Comments From varekova@xxxxxxxxxx 2007-02-19 07:18 EST ------- (In reply to comment #1) Thanks for your comment. > * the source is not one of those appearing on the home page. Moreover > you could use the tar.bz2. fixed source tag > * Is Prefix: %{_prefix} needed? I prefer to leave prefix flag set there. > * BuildRoot is not the preferred one changed > * The comment in %build is misleading. It should better be something like > # prepare Makefile for the static lib changed > and in %install there could be a comment saying > # the first make triggers compilation of the object files, linking of the > # shared library and installs the library > # The second make triggers the linking of the static library and > # its installation this comment is not necessary > * I think it would be better to have, in -devel > http://www.zlib.net/manual.html > and > http://www.zlib.net/zlib_how.html These documents are not part of upstream tarball > * it seems to me that FAQ should be in %doc, and ChangeLog should be > in the main package changed and added > * -devel should > Requires: zlib = %{version}-%{release} changed > * It seems to me that there should be a make clean between the 2 > make -f invocations, to trigger recompilation with the flags without -fPIC > * I'll attach a patch to simplify the build and install, and use more > macros. fixed > * zutil.h seems to be an internal header that should no be shipped removed > * seems like that spec is not in utf8, certainly because of Glomsrød fixed > * remove the dots at the end of the Summaries fixed > Change %defattr(-,root,root) to %defattr(-,root,root,-) changed Fixed version is zlib-1.2.3-5.fc7 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review