Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876401 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #5 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Spec file changes. BuildRequires: perl(ExtUtils::CBuilder) +BuildRequires: perl(Carp) +BuildRequires: perl(Cwd) +BuildRequires: perl(Exporter) +BuildRequires: perl(File::Spec) +BuildRequires: perl(File::Temp) +BuildRequires: perl(lib) > * FIX: Missing BR for tests Ok %files %doc Changes META.json README #%%{perl_vendorlib}/auto/* -%{perl_vendorlib}/ExtUtils* +%{perl_vendorlib}/ExtUtils/ParseXS* +%{perl_vendorlib}/ExtUtils/Typemaps* > TODO: Update %files to prevent duplicity Ok %install -make pure_install PERL_INSTALL_ROOT=%{buildroot} +make pure_install DESTDIR=%{buildroot} > TODO: Replace variable PERL_INSTALL_ROOT obsoleted with DESTDIR name in > %install. Ok find %{buildroot} -type f -name '*.bs' -size 0 -exec rm -f {} \; -find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \; > TODO: Remove the deleting empty directories in %install section. This is > default behavior. Ok Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review