Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871216 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17 |rawhide Summary|Review Request: tupi - Tupi |Review Request: tupi - 2D |Open 2D Magic |vector-based animation | |environment --- Comment #31 from Michael Schwendt <mschwendt@xxxxxxxxx> --- > %dir %_datadir/%{name}/data/ > %dir %_datadir/%{name}/data/cs/ > %dir %_datadir/%{name}/data/da/ > %dir %_datadir/%{name}/data/de/ > %dir %_datadir/%{name}/data/en/ > %dir %_datadir/%{name}/data/es/ > %dir %_datadir/%{name}/data/gl/ > %dir %_datadir/%{name}/data/pt/ > %dir %_datadir/%{name}/data/ru/ > %{_datadir}/%{name}/data/*/gpl.css > %{_datadir}/%{name}/data/*/*.xml > %{_datadir}/%{name}/data/*/*.html > > %dir %_datadir/%{name}/data/palettes/ > %{_datadir}/%{name}/data/palettes/*.tpal > > %dir %_datadir/%{name}/data/help/ > %dir %_datadir/%{name}/data/help/css/ > %{_datadir}/%{name}/data/help/css/tupi.ini > > %dir %_datadir/%{name}/data/help/en/ > %dir %_datadir/%{name}/data/help/es/ > %dir %_datadir/%{name}/data/help/ru/ > %dir %_datadir/%{name}/data/help/examples/ > %{_datadir}/%{name}/data/help/examples/example.* > > %dir %_datadir/%{name}/data/help/gl/ > > %dir %_datadir/%{name}/data/help/images/ > %{_datadir}/%{name}/data/help/images/*.png > %{_datadir}/%{name}/data/help/*/*.html > %{_datadir}/%{name}/data/help/*/*.xml > %{_datadir}/%{name}/data/help/*/*.css > %{_datadir}/%{name}/data/help/*/images/*.png > > %dir %_datadir/%{name}/data/help/to_translate/ > %_datadir/%{name}/data/help/to_translate/* > > %dir %_datadir/%{name}/data/help/README/ > %{_datadir}/%{name}/data/help/README/* > > %dir %_datadir/%{name}/data/storyboard/ > %{_datadir}/%{name}/data/storyboard/tupi.css > > %dir %_datadir/%{name}/data/translations/ > %{_datadir}/%{name}/data/translations/*.ts > > %dir %_datadir/%{name}/themes/ > %dir %_datadir/%{name}/themes/default/ > %dir %_datadir/%{name}/themes/default/cursors/ > %dir %_datadir/%{name}/themes/default/icons/ > %dir %_datadir/%{name}/themes/default/images/ > %_datadir/%{name}/themes/*/*/*.png > > %dir %_libdir/%{name}/ > %{_libdir}/%{name}/* As can be concluded from this overly complex %files section, you are probably not aware of the much easier notation to include entire trees of files/directories. The entry %{_datadir}/%{name}/ and also %{_datadir}/%{name} (without the trailing slash) would include a directory %{_datadir}/%{name}/ and everything in it. Implicitly creating %dir entries for any directories and avoiding "unowned" directories, too: https://fedoraproject.org/wiki/Packaging:UnownedDirectories Listing each and every directory and file(s) as you did could become burdensome to maintain, if the installation layout changes even slightly. Listing individual files (without a '*' wildcard) typically is only beneficial if you want the rpmbuild to fail if a specific file is not found in the buildroot. > %dir %_libdir/%{name}/ > %{_libdir}/%{name}/* In the same way, this can be simplified to just %{_libdir}/%{name}/ and will achieve the same. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review