Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libhangul - Hangul input library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217671 ------- Additional Comments From petersen@xxxxxxxxxx 2007-02-18 21:46 EST ------- Here is the review: = rpmlint gives: W: libhangul-devel no-documentation but I think this is probably ok + package naming is good + spec filename matches package name + meets packaging guidelines + license is LGPL + license in spec file is correct + COPYING file is included in %doc files - I attach a small patch to improve the English descriptions + spec file is legible + md5sum matches upstream tarball a32301e03a381917cb2ec836a43a9664 libhangul-0.0.4.tar.gz + builds on fc6 i386 + no build dependencies + no translations + has correct ldconfig scripts + owns all its directories + no duplicate files in filelists + has %defattr lines + has %clean + macro use is consistent + no large documentation + %doc files do not affect runtime + has devel subpackage + devel requires pkgconfig + lib*.so is in -devel + devel package requires main package with full nvr + removes .la file + only owns its own dirs -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review