Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882713 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hdegoede@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |hdegoede@xxxxxxxxxx Flags| |fedora-review? --- Comment #1 from Hans de Goede <hdegoede@xxxxxxxxxx> --- Hi, I'll take this one for review. Full review done: Good: ===== - package meets naming guidelines - package meets packaging guidelines - license (GPLv3) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime Needs work: =========== - rpmlint checks return: gdigi.x86_64: W: incoherent-version-in-changelog 0.3.0-20121202git.1.fc17 ['0.3.0-20121202git.1.fc18', '0.3.0-20121202git.1'] gdigi-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gdigi-0.3.0/gtkknob.c gdigi-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gdigi-0.3.0/gtkknob.h Please fix the incoherent changelog issue -please drop the "Requires: expat gtk3", rpm automatically detects this dependecies based on soname: rpm -qp --requires ~/rpmbuild/RPMS/x86_64/gdigi-0.3.0-20121202git.1.fc18.x86_64.rpm <snip> libexpat.so.1()(64bit) <snip> libgtk-3.so.0()(64bit) -gdigi has a .desktop file so this applies: http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files Thus there must be a: desktop-file-validate %{buildroot}/%{_datadir}/applications/foo.desktop line at the end of the %install section -please drop the BuildRoot, rm -rf %{buildroot} in %install and %clean section they are no longer nescessary. -please drop the %defattr, they are no longer necessary -please do not gzip the manpage before install rpmbuild will take care of compressing it in its install destination, and if we ever decide to move from gzip to for example bz2, then rpmbuild will automatically do the right thing. Please provide a new version fixing the needs work issues, with the Release field bumped, and a specfile changelog entry describing the changes made. Thanks & Regards, Hans -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review