Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=882704 --- Comment #2 from Alon Bar-Lev <alonbl@xxxxxxxxxx> --- Attach the report and my notes '-->', I hope I got this correctly. This is a pre-release, however, I would like to know that all OK. Thanks! --- Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= [!]: Packages have proper BuildRequires/Requires on jpackage-utils See: https://fedoraproject.org/wiki/Packaging:Java --> This is false positive, we only need jpackage-utils for the java subpackage. [!]: Package DOES NOT use %update_maven_depmap in %post/%postun See: https://fedoraproject.org/wiki/Packaging:Java#add_maven_depmap_macro [!]: Fully versioned dependency in subpackages, if present. Note: Missing: 'Requires: %%{name} =' in: %package devel See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage --> This is false positive as the devel package depends on the java package which depends on the base package correctly. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. --> LGPLv2.1+ [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [?]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in %package javadoc, %package devel [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. --> This is false positive as the devel package depends on the java package which depends on the base package correctly. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later)". 1 files have unknown license. Detailed output of licensecheck in /home/test1/review-otopi/licensecheck.txt --> False positive. [x]: License file installed when any subpackage combination is installed. --> Except for the javadoc subpackage. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [x]: Package is not relocatable. [x]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 51200 bytes in 6 files. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [!]: Packages have proper BuildRequires/Requires on jpackage-utils --> This is false positive, we only need jpackage-utils for the java subpackage. [!]: Fully versioned dependency in subpackages, if present. Note: Missing: 'Requires: %%{name} =' in: %package devel --> This is false positive as the devel package depends on the java package which depends on the base package correctly. [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) [x]: Bundled jar/class files should be removed before build Maven: [!]: Pom files have correct add_maven_depmap call Note: Some add_maven_depmap calls found. Please check if they are correct --> This is false positive. [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [!]: Package DOES NOT use %update_maven_depmap in %post/%postun --> This is false positive, we only need %update_maven_depmap for the java subpackage. [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms Python: [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [?]: Buildroot is not present Note: Buildroot: present but not needed [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. [-]: Scriptlets must be sane, if used. [?]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: SourceX / PatchY prefixed with %{name}. [x]: SourceX is a working URL. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define. Java: [x]: Package has BuildArch: noarch (if possible) [x]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: otopi-devel-0.0.0-0.0.master.fc17.noarch.rpm otopi-javadoc-0.0.0-0.0.master.fc17.noarch.rpm otopi-java-0.0.0-0.0.master.fc17.noarch.rpm otopi-0.0.0-0.0.master.fc17.noarch.rpm otopi-0.0.0-0.0.master.fc17.src.rpm otopi-devel.noarch: W: summary-not-capitalized C otopi development components otopi-devel.noarch: W: no-documentation otopi-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados otopi-java.noarch: W: summary-not-capitalized C otopi java support otopi-java.noarch: W: no-documentation otopi.noarch: W: spelling-error Summary(en_US) oVirt -> overt otopi.noarch: W: summary-not-capitalized C oVirt Task Oriented Pluggable Installer/Implementation (otopi) otopi.noarch: W: incoherent-version-in-changelog 0.0.0-0 ['0.0.0-0.0.master.fc17', '0.0.0-0.0.master'] otopi.noarch: E: non-executable-script /usr/share/otopi/plugins/otopi/packagers/miniyum.py 0644L /usr/bin/python otopi.noarch: W: no-manual-page-for-binary otopi otopi.src: W: spelling-error Summary(en_US) oVirt -> overt otopi.src: W: summary-not-capitalized C oVirt Task Oriented Pluggable Installer/Implementation (otopi) otopi.src:131: W: macro-in-comment %{_datadir} otopi.src:131: W: macro-in-comment %{name} otopi.src: W: invalid-url Source0: http://resources.ovirt.org/releases/stable/src/otopi-0.0.0_master.tar.gz HTTP Error 404: Not Found 5 packages and 0 specfiles checked; 1 errors, 14 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint otopi-java otopi otopi-javadoc otopi-devel otopi-java.noarch: W: summary-not-capitalized C otopi java support --> otopi - as-is otopi-java.noarch: W: no-documentation --> unclear? otopi.noarch: W: spelling-error Summary(en_US) oVirt -> overt --> False positive. otopi.noarch: W: summary-not-capitalized C oVirt Task Oriented Pluggable Installer/Implementation (otopi) --> oVirt - as-is otopi.noarch: W: incoherent-version-in-changelog 0.0.0-0 ['0.0.0-0.0.master.fc17', '0.0.0-0.0.master'] --> will modify. otopi.noarch: E: non-executable-script /usr/share/otopi/plugins/otopi/packagers/miniyum.py 0644L /usr/bin/python --> not required otopi.noarch: W: no-manual-page-for-binary otopi --> not required otopi-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados --> false positive otopi-devel.noarch: W: summary-not-capitalized C otopi development components --> otopi - as-is otopi-devel.noarch: W: no-documentation --> unclear? 4 packages and 0 specfiles checked; 1 errors, 9 warnings. # echo 'rpmlint-done:' Requires -------- otopi-devel-0.0.0-0.0.master.fc17.noarch.rpm (rpmlib, GLIBC filtered): /bin/sh otopi-java = 0.0.0-0.0.master.fc17 python(abi) = 2.7 otopi-javadoc-0.0.0-0.0.master.fc17.noarch.rpm (rpmlib, GLIBC filtered): jpackage-utils otopi-java-0.0.0-0.0.master.fc17.noarch.rpm (rpmlib, GLIBC filtered): /bin/sh apache-commons-logging java jpackage-utils otopi = 0.0.0-0.0.master.fc17 otopi-0.0.0-0.0.master.fc17.noarch.rpm (rpmlib, GLIBC filtered): /bin/sh python python(abi) = 2.7 Provides -------- otopi-devel-0.0.0-0.0.master.fc17.noarch.rpm: otopi-devel = 0.0.0-0.0.master.fc17 otopi-javadoc-0.0.0-0.0.master.fc17.noarch.rpm: otopi-javadoc = 0.0.0-0.0.master.fc17 otopi-java-0.0.0-0.0.master.fc17.noarch.rpm: mvn(org.ovirt.otopi:otopi) otopi-java = 0.0.0-0.0.master.fc17 otopi-0.0.0-0.0.master.fc17.noarch.rpm: otopi = 0.0.0-0.0.master.fc17 MD5-sum check ------------- Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-17-x86_64 Command line :/bin/fedora-review --rpm-spec --name=/home/test1/rpmbuild/SRPMS/otopi-0.0.0-0.0.master.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review