[Bug 875087] Review Request: pbsclusterviz - Visualise the status of PBS clusters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=875087

--- Comment #2 from Paul Cochrane <paultcochrane@xxxxxxxxx> ---
Hi Volker,

many thanks for your comments!  I've changed as many things as I could and have
uploaded the latest spec file and SRPM to the following URLs:

http://sourceforge.net/projects/pbsclusterviz/files/pbsclusterviz%200.7/pbsclusterviz.spec
http://sourceforge.net/projects/pbsclusterviz/files/pbsclusterviz%200.7/pbsclusterviz-0.7a-2.src.rpm

(In reply to comment #1)
> Thank you for your contribution. You must become a packager to maintain
> packages in Fedora.
> 
> https://fedoraproject.org/wiki/Join_the_package_collection_maintainers

I'm working my way through the process now.

> I left a comment on the ticket that you'll need a sponsor first.

I'm pretty sure I had a sponsor for some old projects of mine ('xmds' and
'pyscript') so I don't know if that helps at all in this case.

> vtk is only in EPEL 6. If you want your package to appear in EPEL 5, you'll
> have to convince the vtk maintainer to create a build there. :)

Hrm, strange.  I've got the code running on a ScientificLinux5 system
(basically RHEL5).  Maybe it's possible to get python-vtk etc from the DAG or
ATRPMS repos (which are also activated on that system) and that's the reason
that pbsclusterviz works there.

> License is GPLv2+
> 
> Use the name and version macro in Source0.
> 
> You don't need defattr anymore.

Corrected in current .spec file.

> You must own %{_sysconfdir}/pbsclusterviz.d. and
> %{python_sitelib}/pbsclusterviz

Sorry, I don't know what you mean here.  root should own the files, right?  How
do I set the ownership properly?

> Drop all version constraints from BuildRequires. No maintained release of
> Fedora or EL has older versions. I don't know whether you need those
> packages while you're building. But if you need them during operation,
> you'll have to make them Requires.

Ok, I've corrected this in the current .spec file.  Hopefully it's now what's
expected.

> Installed (but unpackaged) file(s) found:
> /usr/lib/python2.7/site-packages/pbsclusterviz-0.7a-py2.7.egg-info

Strange, I don't get this file when building and installing the package. 
Should I just add this to the .spec file?  Or leave it as is?

> Also include AUTHORS and COPYING. The postal address in COPYING is outdated.

Updated and corrected as necessary.

Many thanks again for your help!

Kind regards,

Paul

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]