[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=878556

--- Comment #5 from Miroslav Suchý <msuchy@xxxxxxxxxx> ---
>%check
>cd %{buildroot}%{gem_instdir}
>testrb2 -Ilib test

It is prefered to do:
%check
pushd .%{gem_instdir}
testrb2 -Ilib test
popd

Because if that test accidentally change something in files which will land in
package, then if you are running the test in %{buildroot}%{gem_instdir}, this
change will land in package as will. But if you run it in .%{gem_instdir}, then
such accidential change will be isolated. This is behavior "just-in-case".

It is very good habbit to bump up release number for every change of spec....
Ah, you put here wrong link. Ok I deducted:
http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov-0.7.1-2.fc18.src.rpm

Again:
export CONFIGURE_ARGS="--with-cflags='%{optflags}'"
# gem install compiles any C extensions and installs into a directory
does not have sense here.

Please fix that directory in %check again, and that will be all.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]