Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881096 Pádraig Brady <pbrady@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Pádraig Brady <pbrady@xxxxxxxxxx> --- [!]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: make i.e. remove make from buildrequires [!]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. i.e. add "%doc LICENSE" to %files [!]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. Note: packstack.spec should be openstack-packstack.spec second line of description. s/variouse/various/ third line of description has a trailing space s/186/188 in changelog There are lots of hidden files in the tarball, including .git/ dirs There are lots of scripts identified as such by the first line being #!/usr/bin/env ... that are not executable For example: parseyaml_spec.rb If they're not meant to be executed directly, then you could remove the first line upstream, or in the spec %prep do: find nova -name \*.rb -exec sed -i '/\/usr\/bin\/env ruby/{d;q}' {} + -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review