Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=877763 --- Comment #7 from Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> --- (In reply to comment #6) > I couldn't to use this application. When I started it it has no any photos > and I couldn't find any way to add them. You need to have Tracker running and indexing your photos in ~/Pictures. There is no way to « add » pictures to it, it finds them automatically. > In .spec you use https://live.gnome.org/Design/Apps/Photos but About of > Gnome-Photos used https://live.gnome.org/GnomePhotos. > Probably it should be fixed. I didn't know about this URL, so I used the other one. Fixed. > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses found: > "GPL (v2 or later) (with incorrect FSF address)", "LGPL (v2 or later)", > "GPL (v2 or later)", "Unknown or generated". 4 files have unknown > license. Detailed output of licensecheck in /home/taurus/877763-gnome- > photos/licensecheck.txt > Use GPLv2+ and LGPLv2+ for License tag Good catch! Fixed. > [!]: %check is present and all tests pass. I guess that's a note for Debarshi to add unit tests upstream. :P > [!]: Packages should try to preserve timestamps of original installed files. Doh, I asked you to fix it in NetworkManager-l2tp and I can't do it properly in my own package. :) Fixed. ----- Spec URL: http://bochecha.fedorapeople.org/packages/gnome-photos.spec SRPM URL: http://bochecha.fedorapeople.org/packages/gnome-photos-3.7.2-3.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review