[Bug 880763] Review Request: AudioCuesheetEditor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=880763

--- Comment #2 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> ---
(In reply to comment #0)

> ./configure
> make
> make install

Hi Sven,

in an rpm spec file, you should use the %configure macro, see
https://fedoraproject.org/wiki/Packaging:RPMMacros

You also want to speed up the build by using more than one processor, see
https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make

And last but not least you want to preserve timestamps during install, see
https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps

This results in

  %configure
  make %{?_smp_mflags}
  make install 'INSTALL=install -p'

Your package still needs a lot of work before it can be included in Fedora.
Please read https://fedoraproject.org/wiki/Packaging:Guidelines and try to
improve it. It's not that hard and you are doing fine. Keep up the good work!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]