Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=881443 Eduardo Echeverria <echevemaster@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |echevemaster@xxxxxxxxx --- Comment #1 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- Hi Mohammed: Initial comments: - Don't use rm -rf $RPM_BUILD_ROOT in %install, only required if build you the package for epel5 - There is a faster way to convert a file from DOS to UNIX : sed -i -e 's/\r$//g' file - The package does not include a license file, and as reflected in the guidelines: "If the source package does not include the text of the license(s), the packager should contact upstream and encourage them to correct this mistake." See https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text In the source, run licensecheck -r * in the directory src, you'll find the following output: licensecheck -r * 3way.c: GPL (v2 or later) bf_tab.h: *No copyright* UNKNOWN blowfish.c: GPL (v2 or later) blowfish.h: *No copyright* UNKNOWN Bra86.c: *No copyright* UNKNOWN Bra.h: *No copyright* UNKNOWN des.c: LGPL (v2.1) des.h: *No copyright* UNKNOWN dunno.c: GPL (v2 or later) gost.c: GPL (v2 or later) idea.c: MIT/X11 (BSD like) GPL (v2 or later) loki91.c: GPL (v2 or later) loki.h: GPL (v2 or later) LzmaDec.c: *No copyright* UNKNOWN LzmaDec.h: *No copyright* UNKNOWN magiciso_is_shit.h: GPL (v2 or later) rc5.c: GPL (v2 or later) seal.c: GPL (v2 or later) Types.h: *No copyright* UNKNOWN uif2iso.c: GPL (v2 or later) In my experience, when there are many licenses involved in the upstream source files and these licenses do not apply to your own source, is clear indication that may contain bundled libs or bundled files See https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries In some of these files, I see upstream comments */ // modified by Luigi Auriemma for emulating the shameful customizations of Magic ISO /* Check these files to see if these incurred in the policy "no bundled lib" - Please remove uif2iso.exe Regards -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review