Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: bzip2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225633 ------- Additional Comments From pertusus@xxxxxxx 2007-02-18 07:58 EST ------- Seems almost right to me, still 2 issues and some suggestions: * remove 'static library' from the -devel package description since there is no static library * the original soname don't follow the usual convention of a soname number with an integer, but I am not certain that it is right to modify it in fedora. It should better be changed upstream. What is the reasoning behind this change? Suggestions: * move chmod 644 bzlib.h chmod 644 bzip2.1 bzdiff.1 bzgrep.1 bzmore.1 to %prep, since these perms should be like that in the tarball * remove the / between $RPM_BUILD_ROOT and macros, like %{_mandir}, %{_libdir}... since they allready have a leading / * for %patch6, maybe it could be %patch6 -p1 -b .bzip2recover * The changelog entries 'incorporate the next review feedback' are not particularly useful, I agree that for simple changes it is right, but here there was a complete reorganization of the build between 2 release, removal of static lib, this would have, in my opinion, deserved a more verbose changelog A remark: * I completely agree with the new organization of the spec with build in %build and install in %install, I would have asked for that the next round anyway ;-) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review