[Bug 881086] Review Request: rubygem-audited-activerecord - Log all changes to your ActiveRecord models

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=881086

Miroslav Suchý <msuchy@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |
              Flags|                            |fedora-review+

--- Comment #1 from Miroslav Suchý <msuchy@xxxxxxxxxx> ---
I would suggest to add to the end of %install:
rm -rf %{buildroot}%{gem_instdir}/.yardoc
so rpmbuild --rebuild will pass on systems where rubygem-yard is installed. But
it is not crucial since in koji it is not installed.

I prefer to move
mkdir -p .%{gem_dir}
gem install --local --install-dir .%{gem_dir} \
            --force %{SOURCE0}
from %prep to %build

But all this is minor and does not block review.
Everything else is perfect.

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]