Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=863569 --- Comment #6 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- $ rpmlint *.rpm log4c.src: W: spelling-error %description -l en_US syslog -> slog 1 packages and 0 specfiles checked; 0 errors, 1 warnings. naming: ok license: NOT ok 1. MUST add license file %doc COPYING while, we're at it, may as well add %doc AUTHORS ChangeLog README as well macros: ok sources: ok 6dae664d3ce052ce8f99b249f094d152 log4c-1.2.2.tar.gz builds/installs: ok there's a few SHOULD items I'd like you to consider: 2. SHOULD track library soname use %{_libdir}/liblog4c.so.3* instead of %{_libdir}/liblog4c.so.* 3. SHOULD drop deprecated items from .spec, if you're supporting fedora and/or rhel >=6, like Group: tags BuildRoot: tags %defattr tags %clean section rm -rf %{buildroot} (from beginning of %install section) 4. SHOULD drop from -devel: Requires: automake rpm -q -f /usr/share/aclocal filesystem-3.1-2.fc18.x86_64 is already owned by filesystem package in recent versions of fedora -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review