Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: yum-arch - Extract headers from rpm in a old yum repository https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229123 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2007-02-18 01:56 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 734cc68e26c2fd07629616ab597acac6 yum-2.2.2.tar.gz 734cc68e26c2fd07629616ab597acac6 yum-2.2.2.tar.gz.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. See below - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version Issues: 1. You should own the %{_datadir}/%{name}/ directory. 2. rpmlint says: a) E: yum-arch explicit-lib-dependency libxml2-python This can be ignored. rpm can't find the needed dependency here, so adding a Requires should be ok. b) E: yum-arch non-executable-script /usr/share/yum-arch/callback.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/cli.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/i18n.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/output.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/pullheaders.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/repomd/mdErrors.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/repomd/mdUtils.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/repomd/packageObject.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/repomd/packageSack.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/repomd/repoMDObject.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/repomd/test.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/rpmUtils/arch.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/rpmUtils/__init__.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/rpmUtils/miscutils.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/rpmUtils/oldUtils.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/rpmUtils/transaction.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/rpmUtils/updates.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/serverStuff.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/yum/archwork.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/yum/comps.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/yum/config.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/yum/depsolve.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/yum/Errors.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/yum/failover.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/yum/groups.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/yum/__init__.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/yummain.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/yum/mdcache.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/yum/packages.py 0644 E: yum-arch non-executable-script /usr/share/yum-arch/yum/repos.py 0644 These are all due to those files having a: #!/usr/bin/python -t at the top. Perhaps that could be stripped out, since they should never be executed directly... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review