[Bug 815018] Review Request: nodejs - javascript fast build framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=815018

--- Comment #48 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> ---
(In reply to comment #45)
> I've spent the last couple weeks working with upstream to complete the
> unbundling process. I can now present to the world a copy of Node.js built
> entirely against system libraries!
> 
> Spec: http://sgallagh.fedorapeople.org/packagereview/nodejs/nodejs.spec
> SRPM:
> http://sgallagh.fedorapeople.org/packagereview/nodejs/nodejs-0.9.3-3.fc18.
> src.rpm
> 
> Built in Koji for Rawhide:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=4706430

Awesome!  The only remaining issue with this packaging I see is the
/usr/bin/node conflict with the node package.

> Some notes: I'm not building npm in this tarball. It will be better to open
> a separate review for the upstream tarballs of npm located at
> https://github.com/isaacs/npm/tags. This tarball includes with it a number
> of modules and as such needs the care and feeding that a separate package
> provides.

Those modules should actually be packaged separately.  I'll revive my old npm
reviews and create new ones for the newly required modules soon.

> Thus, this package contains only the node binary and the manpage for it,
> properly linked against system libraries.
> 
> I'm not an expert in Node.js development. I've only tested that this binary
> works with some simple tutorial examples I found at www.nodebeginner.org.
> I'm certainly open to comaintainers helping me out here.

I have a general sense of how node software should be shipped in an RPM world
and already have automatic RPM dependency generation sorted out.  I'll work on
draft packaging guidelines for node packages and submit them to FPC.  I'll also
fix up the necessary RPM magic and macros and provide a patch to the new
packaging to include them.

(P.S.  I presently maintain http-parser and am working to update the ancient
version to the latest and greatest.  Please feel free to request ACLS in pkgdb
if you want/need them.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]