Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879933 --- Comment #3 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> --- Susi Lehtola thanks to the hint. (In reply to comment #1) > The build fails for me: > > " > -- Looking for C++ include OIS.h - not found > could not find the OIS includes. Please install them. > " > > Not sure if this is the cause though. > ?_isa (See SocketW comment!) fixed > /usr has a macro It is not sense in case of clearing unneeded files in string: rm -rf %{buildroot}/usr/doc because it is not install by correct path but clearing garbage instead by hardcoded path in build directory. > I think it should be enough to include lgpl.txt. And exclude gpl.txt? Why? > "Requires: pkgconfig" should be in the section of the devel package > and possibly as BR Moved. But I think it should be Require dependency. Please look at http://fedoraproject.org/wiki/Packaging:Guidelines#Pkgconfig_Files_.28foo.pc.29 and http://fedoraproject.org/wiki/Archive:PackagingDrafts/pkgconfig As moovind into devel is good catch, it may be also used by developer by hand as pkgconfig provide cli tool to query database. > > BR cmake Fixed. > > Is this really a system wide library or rather a private one? I threat it as system library. Why you are doubt? http://hubbitus.info/rpm/Fedora17/caelum/caelum.spec http://hubbitus.info/rpm/Fedora17/caelum/caelum-0.6.1-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review