Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878236 Gianluca Sforna <giallu@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #4 from Gianluca Sforna <giallu@xxxxxxxxx> --- (In reply to comment #3) > I've updated the package with all your suggestions except the > CFLAGS="$RPM_OPT_FLAGS" thing. This package does not have any C extensions > so I think the CFLAGS are not needed. I guess the guidelines try to cover > all cases but this time is cleaner if we don't put that. Yeah. I suppose it could grow such extension in the future, but I trust your packager powers to fix it in case it will ever do :) I think we are in a good shape to go. Just a minor remark: I suggest you use the %{version} macro in the Source0 line, so you don't need to change it at each new upstream release. ==== REVIEW CHECKLIST ==== - package named according to package naming guidelines - package licensed with allowed license (ZPLv2.1) - license matches actual license - license file included in %doc - spec written in American english - spec legible - sources match upstream sha256sum - successfully builds in mock for rawhide x86_64 - no locales - no shared libraries - package owns all directories it creates - default file permissions - macro usage is consistent - package contains code - no large documentation - not a GUI app needing a .desktop file - rpmlint is mostly silent, the only warning can be ignored: rpmlint /var/lib/mock/fedora-17-x86_64/result/*.rpm python-waitress.src: W: spelling-error %description -l en_US usr -> use, us, user 3 packages and 0 specfiles checked; 0 errors, 1 warnings. This package is APPROVED PS. I have a package in the queue as well, bug #804125. If you have spare cycles to help me get it in Fedora it would be great. However, it is much more complicated than this one, so do not feel obligated in any way. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review