Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=880155 --- Comment #2 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- $ rpmlint *.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. naming: ok sources: ok 41f6fa67e980733d7d8a2cd881bbe5b4 PackageKit-Qt-0.8.6.tar.gz license: ok $ licensecheck -r src src/daemonprivate.h: LGPL (v2 or later) src/transactionprivate.h: LGPL (v2 or later) src/common.h: LGPL (v2 or later) src/bitfield.cpp: *No copyright* UNKNOWN src/daemonprivate.cpp: LGPL (v2 or later) src/daemon.cpp: LGPL (v2 or later) src/transaction.h: LGPL (v2 or later) src/bitfield.h: *No copyright* UNKNOWN src/transaction.cpp: LGPL (v2 or later) src/transactionprivate.cpp: LGPL (v2 or later) src/daemon.h: LGPL (v2 or later) macros: ok builds/installs: mostly ok, but... 1. MUST: need some Obsoletes (and at least a temporary Provides) here to handle upgrade from older PackageKit-qt... Obsoletes: PackageKit-qt < 0.8.6 Provides: PackageKit-qt = %{version}-%{release} Provides: PackageKit-qt%{?_isa} = %{version}-%{release} and for -devel subpkg: Obsoletes: PackageKit-qt-devel < 0.8.6 Provides: PackageKit-qt-devel = %{version}-%{release} that seems to be the only review blocker i see. there's a handful of smaller SHOULD things we can do, but i'll be happy to wait until after import to help implement that. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review