Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866156 --- Comment #13 from Ismael Olea <ismael@xxxxxxxx> --- Summarizing: [?]: Package functions as described. * Seems my pulseaudio system is not compatible with rtaudio [!]: Latest version is packaged. * last upstream is 0.5.4 [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. * you should contribute desktop file, and the patch if considered useful to upstream and provide the links to those See https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment [!]: Scriptlets must be sane, if used. * as desktop file doesn't include a MimeType key it not needs the update-destkop-database calls See https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review