Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876043 --- Comment #10 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- Hi kevin, Thanks for taking the review (In reply to comment #9) > Issues: > > 1. Is there no upstream place to download the source? If it's not a easy to > use url you > can explain in a comment how to download it. Comment added > 2. (nonblocker) You might mention to upstream the various warnings spit out > in the build. I'll send an email to upstream with the warnings > 3. rpmlint says: > > xfce-theme-manager.i686: W: no-manual-page-for-binary xfce-theme-manager > > Might be nice to make a man page, but not a blocker. I did a man page for the application, today sent it to upstream > xfce-theme-manager-debuginfo.i686: E: debuginfo-without-sources > > debuginfo-without-sources: > This debuginfo package appears to contain debug symbols but no source files. > This is often a sign of binaries being unexpectedly stripped too early during > the build, or being compiled without compiler debug flags (which again often > is a sign of distro's default compiler flags ignored which might have > security > consequences), or other compiler flags which result in rpmbuild's debuginfo > extraction not working as expected. Verify that the binaries are not > unexpectedly stripped and that the intended compiler flags are used. > > You probibly need to patch the build process to use the normal rpm opt flags. Solved SPEC: http://echevemaster.fedorapeople.org/xfce-theme-manager/2/xfce-theme-manager.spec SRPM: http://echevemaster.fedorapeople.org/xfce-theme-manager/2/xfce-theme-manager-0.1.19-2.fc17.src.rpm Koji scratch Builds: rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=4727203 f18: http://koji.fedoraproject.org/koji/taskinfo?taskID=4727214 f17: http://koji.fedoraproject.org/koji/taskinfo?taskID=4727242 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review