Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879903 --- Comment #2 from Dan Horák <dan@xxxxxxxx> --- formal review is here, see the notes explaining OK* and BAD statuses below: OK* source files match upstream: 1a3782f990fe51db30b68de5cf52c46cac0928d1 xorg-x11-drv-armsoc-0.5.1.tar.bz2 OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible (MIT). License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. BAD rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - the URL should probably point to armsoc home (git) and not to X.org home - git archive --format=tar --prefix=%{name}-%{version}/ %{version} | bzip2 > ~/%{name}-%{version}.tar.bz2 is the correct command to recreate the archive (s/%{gittag}-%{version}/%{version}/) - rpmlint complains a bit - please fix the mixed tabs and spaces isue -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review