[Bug 877763] Review Request: gnome-photos - Access, organize and share your photos on GNOME

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=877763

--- Comment #5 from Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> ---
Sorry, I sent my previous comment too early (there seems to be a keyboard
shortcut which validates forms in Epiphany :-/ )

(In reply to comment #2)
> * rpmlint complains about no-manual-page-for-binary, install-file-in-docs,
> invalid-desktopfile, incorrect-fsf-address and macro-in-comment.

- macro-in-comment is because I commented the line where I validate the desktop
file. So when I update to 3.7.3 which has a valid desktop file, I'll uncomment
the line and rpmlint's warning will disappear.

- about incorrect-fsf-address, I'll send you a patch which fixes all the
addresses, so I'll pick that up in 3.7.3 too.

>   - install-file-in-docs and invalid-desktopfile (Thanks Mathieu) have been
> fixed upstream

Not doing anything for these then, I'll pick them up when updating once you
release 3.7.3 :)

> X It should have a BR on gdk-pixbuf2-devel, not gdk-pixbuf2.

Fixed.

> X Pedantically speaking it should have Provides: bundled(libgd). See
> https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
>   - It must be noted that libgd is not meant to be installed as a system
> wide shared library. It is just a way for GNOME applications to share
> widgets and other common code on an ad-hoc basis.

Fixed.

> X Files marked as %doc do not affect the runtime behaviour.
>   - You could consider marking %{_docdir}/%{name} as %doc

rpmbuild does that automatically :)
  $ rpm -qp --docfiles gnome-photos-3.7.2-1.fc18.x86_64.rpm 
  /usr/share/doc/gnome-photos/ARTISTS
  /usr/share/doc/gnome-photos/AUTHORS
  /usr/share/doc/gnome-photos/COPYING
  /usr/share/doc/gnome-photos/ChangeLog
  /usr/share/doc/gnome-photos/INSTALL
  /usr/share/doc/gnome-photos/NEWS
  /usr/share/doc/gnome-photos/README

Spec URL: http://bochecha.fedorapeople.org/packages/gnome-photos.spec
SRPM URL:
http://bochecha.fedorapeople.org/packages/gnome-photos-3.7.2-2.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]