Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=772362 Dan Horák <dan@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #29 from Dan Horák <dan@xxxxxxxx> --- formal review is here, see the notes explaining OK* and BAD statuses below: OK source files match upstream: 541bc65c86158433adb2c5926e3ae43e46ed4fb6 Sigil-0.6.0-Code.zip OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible (GPLv3+). License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. OK* rpmlint is silent. BAD final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK GUI app with desktop file - the spell checker doesn't like ebook and ePub, can be ignored - Provides: bundled(libtidy) needed for bundled stuff is missing APPROVED, please fix the missing Provides before import And one more note - I would like to keep the condition for using the bundled PCRE as I will build the latest sigil packages for older Fedoras in my repo. For Fedora 16 and 17 we can provide sigil 0.5.3 as it doesn't depend on UTF-16 support in pcre. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review