Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=879565 Bug ID: 879565 Summary: Review Request: <bitfrost> - <OLPC security modules> Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Reporter: kparmar4@xxxxxxxxxxx Spec URL: <https://www.dropbox.com/s/h1wnz36hdvi3jqz/bitfrost%20%282%29.spec> SRPM URL: <https://www.dropbox.com/s/qphq6x27ophlhl8/bitfrost-1.0.15-3.0.2.fc17.src.rpm> Description: <Hi, This package is a collection of Python modules which implement parts of Bitfrost, the OLPC security platform. I am working on it as my program's project in which I have to make this package available for x86_64/i686 & ARM architectures. I would appreciate if you would review it for me and give me feedback.> Fedora Account System Username: kparmar4 Output of rpmlint: bitfrost.i686: W: private-shared-object-provides /usr/lib/python2.7/site-packages/bitfrost/util/pysign.so pysign.so A shared object soname provides is provided by a file in a path from which other packages should not directly load shared objects from. Such shared objects should thus not be depended on and they should not result in provides in the containing package. Get rid of the provides if appropriate, for example by filtering it out during build. Note that in some cases this may require disabling rpmbuild's internal dependency generator. bitfrost.i686: W: private-shared-object-provides /usr/lib/python2.7/site-packages/bitfrost/util/pyverify.so pyverify.so A shared object soname provides is provided by a file in a path from which other packages should not directly load shared objects from. Such shared objects should thus not be depended on and they should not result in provides in the containing package. Get rid of the provides if appropriate, for example by filtering it out during build. Note that in some cases this may require disabling rpmbuild's internal dependency generator. bitfrost.i686: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. bitfrost.i686: E: non-executable-script /usr/lib/python2.7/site-packages/bitfrost/leases/crypto.py 0644L /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. bitfrost.i686: E: non-executable-script /usr/lib/python2.7/site-packages/bitfrost/leases/errors.py 0644L /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. bitfrost.i686: E: non-executable-script /usr/lib/python2.7/site-packages/bitfrost/leases/keys.py 0644L /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. bitfrost.i686: E: non-executable-script /usr/lib/python2.7/site-packages/bitfrost/util/urlrange.py 0644L /usr/bin/python This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. bitfrost.i686: E: non-executable-script /usr/lib/python2.7/site-packages/bitfrost/leases/core.py 0644L /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. bitfrost.i686: E: non-executable-script /usr/lib/python2.7/site-packages/bitfrost/util/json.py 0644L /usr/bin/python2.5 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. 1 packages and 0 specfiles checked; 6 errors, 3 warnings. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review