Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: dhcp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225691 ------- Additional Comments From mdehaan@xxxxxxxxxx 2007-02-16 18:56 EST ------- Initial rpmlint scan: [root@mdehaan devel]# rpmlint *.src.rpm W: dhcp invalid-license distributable Given this is the nonstandard ISC license, ok. W: dhcp unversioned-explicit-obsoletes dhcpcd ok. E: dhcp configure-without-libdir-spec I'm not familiar enough with details to say whether or not this is ok. W: dhcp macro-in-%changelog d W: dhcp macro-in-%changelog preun W: dhcp macro-in-%changelog postun W: dhcp mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 253) AFAIK, these shouldn't break anything but if they can be corrected it will make rpmlint happier. W: dhcp patch-not-applied Patch13: dhcp-3.0.5-xen-checksum.patch This patch is commented out in the spec file. I would suggest removing it from the list of patches? --- Spec file looks good at first glance, though I'll look over this in greater depth next week. Leaving as "?" to indicate review still in progress. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review