Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878236 --- Comment #2 from Gianluca Sforna <giallu@xxxxxxxxx> --- Few point we can improve. cosmetic: the 'for more information' part can be rewritten to point user to the full path in the system like this: For more information, see %{docdir}/docs or http://docs.pylonsproject.org/projects/waitress/en/latest/ comparing the spec with the guidelines at https://fedoraproject.org/wiki/Packaging:Python I see it is recommended to run rm -rf %{py3dir} just before cp -a . %{py3dir} Not sure it is useful, but there also minor differences in build and install: CFLAGS="$RPM_OPT_FLAGS" is prepended to setup.py build lines, and setup.py install now lacks the -O1 flag (maybe it was deprecated at some point) pakcage builds fine in mock. rpmlint has few things to say: [giallu@novo SPECS]$ rpmlint /var/lib/mock/fedora-17-x86_64/result/*.rpm python3-waitress.noarch: W: spurious-executable-perm /usr/share/doc/python3-waitress-0.8.2/docs/rebuild python3-waitress.noarch: E: version-control-internal-file /usr/share/doc/python3-waitress-0.8.2/docs/.gitignore python-waitress.noarch: E: version-control-internal-file /usr/share/doc/python-waitress-0.8.2/docs/.gitignore python-waitress.noarch: W: spurious-executable-perm /usr/share/doc/python-waitress-0.8.2/docs/rebuild I guess these are all files you remove outright -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review