[Bug 872957] Review Request: php-pear-XML-SVG - API for building SVG documents

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=872957

Shawn Iwinski <shawn.iwinski@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |shawn.iwinski@xxxxxxxxx

--- Comment #2 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> ---
* In package.xml, is this cross-project baseinstalldir normal?:

<file baseinstalldir="/Horde" md5sum="4c9de300b87bef9f2e967e1b71c1f639"
name="docs/examples/basic.php" role="doc" />
<file baseinstalldir="/Horde" md5sum="0ca5fd8f47288120ebeeaa5a1f97daf3"
name="docs/examples/radialGradient.php" role="doc" />

The files get installed into the correct PEAR document directory, but it just
looks a little strange.



* In %prep, you might want to:

sed '/README/s/role="data"/role="doc"/' -i package.xml

(could also remove "%{pear_datadir}/%{pear_name}" from %files if this is done)



* In %files, instead of:

%{pear_phpdir}/XML

shouldn't it be:

%dir %{pear_phpdir}/XML
     %{pear_phpdir}/XML/SVG

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]